Don't add explanation twice#18779
Merged
nicolasstucki merged 2 commits intoscala:mainfrom Nov 15, 2023
Merged
Conversation
Contributor
Author
|
I expected a test failure. |
Member
|
Some of your puns are too hard for me to parse, but I've come so used to seeing them I was surprised you didn't go for something along the lines of: explain to me once, shame on me, explain to me twice, shame on you... :-P |
nicolasstucki
approved these changes
Nov 6, 2023
Contributor
|
I am wondering if we can test this in |
Contributor
I tried it and that does not work as the extra |
WojciechMazur
added a commit
that referenced
this pull request
Jun 23, 2024
Backports #18779 to the LTS branch. PR submitted by the release tooling. [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18774
The improvement was #14357